Use synthetic recovery source by default if synthetic source is enabled #119110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7bcd751.
| Property.Final | ||
| ); | ||
|
|
||
| /** |
There was a problem hiding this comment.
This change is just a result of reordering settings in such a way that static initialization happens in the right order.
martijnvg
reviewed
Jan 31, 2025
x-pack/plugin/logsdb/build.gradle
Outdated
| tasks.named("yamlRestTest") { | ||
| if (buildParams.isSnapshotBuild() == false) { | ||
| systemProperty 'tests.rest.blacklist', [ | ||
| "resources/rest-api-spec/test/60_synthetic_source_recovery.yml" |
There was a problem hiding this comment.
Looking at other usages, I think this should just be: '60_synthetic_source_recovery/*'?
salvatore-campagna
removed
the
test-release
|
|
💔 Backport failed
You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Feb 5, 2025
…ed (elastic#119110) We experimented with using synthetic source for recovery and observed quite positive impact on indexing throughput by means of our nightly Rally benchmarks. As a result, here we enable it by default when synthetic source is used. To be more precise, if `index.mapping.source.mode` setting is `synthetic` we enable recovery source by means of synthetic source. Moreover, enabling synthetic source recovery is done behind a feature flag. That would allow us to enable it in snapshot builds which in turn will allow us to see performance results in Rally nightly benchmarks. (cherry picked from commit 6a52675)
salvatore-campagna
added a commit
that referenced
this pull request
Feb 6, 2025
… enabled (#119110) (#121760) * Use synthetic recovery source by default if synthetic source is enabled (#119110) We experimented with using synthetic source for recovery and observed quite positive impact on indexing throughput by means of our nightly Rally benchmarks. As a result, here we enable it by default when synthetic source is used. To be more precise, if `index.mapping.source.mode` setting is `synthetic` we enable recovery source by means of synthetic source. Moreover, enabling synthetic source recovery is done behind a feature flag. That would allow us to enable it in snapshot builds which in turn will allow us to see performance results in Rally nightly benchmarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experimented with using synthetic source for recovery and observed quite positive impact
on indexing throughput by means of our nightly Rally benchmarks. As a result, here we enable
it by default when synthetic source is used. To be more precise, if
index.mapping.source.modesetting is
syntheticwe enable recovery source by means of synthetic source.Moreover, enabling synthetic source recovery is done behind a feature flag. That would allow us
to enable it in snapshot builds which in turn will allow us to see performance results in Rally nightly
benchmarks.
This PR needs a refactoring done in #120096.